-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Euros and fixed exchange rate selection page #5566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works surprisingly well. Well done!
The only thing that doesn't work that I could find is the handlebars rendering for euro. You'll find that in the file server/lib/template/helpers/finance.js
. You need to add the configuration for Euro, inc,luding the currency symbol. The FC and USD are already defined there. It will make our receipts render euro when they are paid in euro instead of the default $.
Here is an example of the logic working, but not the currency rendering:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works well. Thanks @jmcameron !
I made one comment about unifying the format of the euro on the client and server (handlebars). I think they both should use commas for decimals and a thin non-breaking whitespace for the thousands space.
bors r+ |
Merge conflict. |
bors r+ |
Merge conflict. |
bors r+ |
Build succeeded: |
Added support for Euros and added related currency and exchange rate tests.
WARNINGS
TESTING
NOTES