Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions - Access violation crash #1293

Open
jonpas opened this issue Oct 2, 2023 · 1 comment
Open

Extensions - Access violation crash #1293

jonpas opened this issue Oct 2, 2023 · 1 comment

Comments

@jonpas
Copy link
Member

jonpas commented Oct 2, 2023

One member got a TS3 crash with build 1055 towards the end of the mission. Only 1 crash was reported, it was not repeating. Dump points to ACRE2. Maybe something from #1240 @PabstMirror?

 	acre2_win64.dll!memcpy() Line 338	Unknown
>	acre2_win64.dll!CSoundChannelMono::In(short * samples, int sampleCount, const int channels) Line 58	C++
 	acre2_win64.dll!CSoundEngine::onEditPlaybackVoiceDataEvent(unsigned int id, short * samples, int sampleCount, int channels) Line 41	C++
 	acre2_win64.dll!ts3plugin_onEditPlaybackVoiceDataEvent(unsigned __int64 server, unsigned short id, short * samples, int sampleCount, int channels) Line 58	C++
 	[Frames may be missing, no binary loaded for ts3client_win64.exe]	
 	[External Code]	

this->bufferLength += sampleCount;

@jonpas jonpas added the bug label Oct 2, 2023
@jonpas jonpas added this to the 2.12.0 milestone Oct 2, 2023
@PabstMirror
Copy link
Collaborator

It's in the normal channels == 1 code path, which was unchanged by #1240
The actual segfault is in memcpy but I'm not sure yet why

memcpy

@jonpas jonpas modified the milestones: 2.12.0, Backlog Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants