Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSContactor and phase_frac #1573

Open
dallan-keylogic opened this issue Feb 20, 2025 · 0 comments
Open

MSContactor and phase_frac #1573

dallan-keylogic opened this issue Feb 20, 2025 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers Priority:Low Low Priority Issue or PR PrOMMiS Issues related to PrOMMiS activities

Comments

@dallan-keylogic
Copy link
Contributor

Presently, the MSContactor model adds phase fraction variables whether or not they already exist on a StateBlock. As a result, it cannot be used with property packages that already have a phase_frac variable, such as the entire modular property framework. All that's needed to fix this issue is to add a check to see if phase_frac already exists (this approach is already implemented in the ControlVolume blocks).

@dallan-keylogic dallan-keylogic self-assigned this Feb 20, 2025
@dallan-keylogic dallan-keylogic added bug Something isn't working good first issue Good for newcomers Priority:Low Low Priority Issue or PR PrOMMiS Issues related to PrOMMiS activities labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Priority:Low Low Priority Issue or PR PrOMMiS Issues related to PrOMMiS activities
Projects
None yet
Development

No branches or pull requests

1 participant