PetabImporter.create_edatas creates incomplete edata objects.

[FFroehlich]

This function appears pretty useless on it's own as fixed parameters etc from the condition table are not filled in. Would expect that the generated objects have partial information that is set by amici.petab.conditions.fill_in_parameters.

[dweindl]

I think that was intentional, but the intention is not sufficiently-well documented.
Nevertheless, I agree that it's probably less surprising if the parameters already get set in there, even if they will have to be updated for the next objective call.

So, I'd be fine with directly calling fill_in_parameters from within create_edatas.