Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review, directory structure #2

Open
ameenetemady opened this issue Jan 31, 2020 · 0 comments
Open

Code Review, directory structure #2

ameenetemady opened this issue Jan 31, 2020 · 0 comments

Comments

@ameenetemady
Copy link
Collaborator

  1. Rename "code" directory to "R". See examples 1, 2.
  2. Consider having "data", "data/input" and "data/output". Currently you have "data" and "out_data" which is not ideal.
  3. File setpath.R seems extra (with only two lines). Remove it.
  4. Rename run_one_setting.sh to run.sh and move it to base directory.
  5. The generate_setting directory only contains a single file. Move the file to be with the rest of the code.
  6. Remove the file named code/workhorse/.nfs0000000007b8271b00000630
  7. The workhorse directory is adding an extra, unnecessary level. Move all to ./R directory under the base.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ameenetemady