Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelCheckpoint must be defined in the config dict, not during the parsing. #454

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ModelCheckpoint must be defined in the config dict, not during the parsing. #454

wants to merge 4 commits into from
+21 −16

Conversation

Joao-L-S-Almeida
Copy link
Member

@Joao-L-S-Almeida Joao-L-S-Almeida commented Feb 24, 2025 •
edited
Loading

It should avoid the issue:

    raise MisconfigurationException(
lightning.fabric.utilities.exceptions.MisconfigurationException: Trainer was configured with `enable_checkpointing=False` but found `ModelCheckpoint` in callbacks list.

@Joao-L-S-Almeida
ModelCheckpoint must be defined in the config dict, not during the pa…
93fa06b 
…rsing

Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Feb 24, 2025
@Joao-L-S-Almeida Joao-L-S-Almeida linked an issue Feb 24, 2025 that may be closed by this pull request
enable_checkpointing=False not possible #436
Open
@Joao-L-S-Almeida
This block is no more required
13f8e5f 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Updating config dicts
81441c6 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida
Namespaces not dicts
fc8c837 
Signed-off-by: João Lucas de Sousa Almeida <joao.l.sa.9.3@gmail.com>
@Joao-L-S-Almeida Joao-L-S-Almeida added bug Something isn't working 0.99.9 labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romeokienzler romeokienzler Awaiting requested review from romeokienzler

@blumenstiel blumenstiel Awaiting requested review from blumenstiel

At least 1 approving review is required to merge this pull request.

Assignees

@Joao-L-S-Almeida Joao-L-S-Almeida

Labels
0.99.9 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable_checkpointing=False not possible
1 participant
@Joao-L-S-Almeida