Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the new datamodules more generic #399

Open
WanjiruCate opened this issue Feb 4, 2025 · 2 comments
Open

Make the new datamodules more generic #399

WanjiruCate opened this issue Feb 4, 2025 · 2 comments
Assignees
Labels

Comments

@WanjiruCate
Copy link

Is your feature request related to a problem? Please describe.
While using the new dataset specific datamodules like Sen1Floods11NonGeoDataModule , it is not possible to pass specific means and stds for another similar dataset i.e like a subset of it.

The new datamodules only accept a data_root that is expected to be a folder with the specified names described in the datasets.

Describe the solution you'd like
With the above problem it is not possible to scale easily for adding different datasets with different folder structures or different statistics.
It should be possible to override the default means, stds, data_root filesof the specific datamodules in the tuning config.

Describe alternatives you've considered (optional)
To continue using the generic datamodules as they allow the requested feature.

Additional context (optional)
Is there any added advantage to use the specific dataset datamodules compared to the generic ones?

@WanjiruCate
Copy link
Author

@Joao-L-S-Almeida here is the issue.

@Joao-L-S-Almeida Joao-L-S-Almeida self-assigned this Feb 4, 2025
@Joao-L-S-Almeida
Copy link
Member

Thanks @WanjiruCate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants