Jest bolt receiver #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barlock
force-pushed
the
jest-bolt-receiver
branch
5 times, most recently
from
38c8551 to
94d45d1
Compare
barlock
commented
Jan 7, 2020
barlock
force-pushed
the
jest-bolt-receiver
branch
from
94d45d1 to
171f7be
Compare
Merged
tteltrab
requested changes
Jan 10, 2020
| let app: MyApp; | ||
|
|
||
| beforeEach(() => { | ||
| receiver = new JestReceiver(); |
There was a problem hiding this comment.
I don't think you need to do this in the beforeEach? Slows down the tests.
this works, I think, and will for most users?
describe('My Awesome App', () => {
const receiver = new JestReceiver();
let app: MyApp;
beforeEach(() => {
app = new App({ receiver, token: fields.token });
});
it('Can handle a slash command', async () => {
...or you can just it in a before instead of a beforeEach if you want for setup. but ^ seems to work.
| @@ -0,0 +1,80 @@ | |||
| # Jest Bolt Receiver | |||
|
|
|||
| A [receiver](https://slack.dev/bolt/concepts#receiver) built for testing Slack Bolt apps with Jest. This receiver allows you to easily send mock events to your app and write consistent tests. | |||
There was a problem hiding this comment.
Having a better description of what you had to do when testing before this package and after would help demonstrate the value more.
| } | ||
|
|
||
| // For things that fall under "Base Events" | ||
| // https://github.com/slackapi/bolt/blob/1655999346077e9521722a667414758da856ede2/src/types/events/base-events.ts |
There was a problem hiding this comment.
why link to a specific tree/commit? why not https://github.com/slackapi/bolt/blob/master/src/types/events/base-events.ts ?
| return event; | ||
| } | ||
|
|
||
| // For things that fall under "Base Events" |
Co-Authored-By: Nick Bartlett <nbartlett7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Supports #8
Related PRs
Depends #21
What does this PR do?
New Package! I present, a bolt receiver, made just for jest. What great tests will come of this.
Description of Changes
Bolt receiver, It's got jest spies in it. It's nice.
What gif most accurately describes how I feel towards this PR?