Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding consumer batch-size matric to sarama #1281

Closed
varun06 opened this issue Feb 12, 2019 · 2 comments · Fixed by #1296
Closed

Adding consumer batch-size matric to sarama #1281

varun06 opened this issue Feb 12, 2019 · 2 comments · Fixed by #1296

Comments

@varun06
Copy link
Contributor

varun06 commented Feb 12, 2019

Problem Description

If I have to expose a consumer batch metric from sarama, is this -> https://github.com/Shopify/sarama/blob/master/consumer.go#L519-L545 right place to do it? parseRecords get batch as an argument, can I put len(batch) as consumer-batch-size in metric?

@dim @eapache

@dim
Copy link
Contributor

dim commented Feb 13, 2019

@varun06 sorry this isn't my code, but I assume it depends on the Consumer.Fetch settings in https://github.com/Shopify/sarama/blob/master/config.go#L244

@varun06
Copy link
Contributor Author

varun06 commented Feb 13, 2019

Thanks. I shall keep looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants