feat(VPCInstanceAuthenticator): add support for new VPC authentication flow #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 99.52% 99.66% +0.14%
==========================================
Files 22 24 +2
Lines 835 906 +71
==========================================
+ Hits 831 903 +72
+ Misses 4 3 -1
Continue to review full report at Codecov.
|
rmkeezer
approved these changes
Oct 28, 2021
ibm_cloud_sdk_core/token_managers/vpc_instance_token_manager.py
Outdated
Show resolved
Hide resolved
ibm_cloud_sdk_core/token_managers/vpc_instance_token_manager.py
Outdated
Show resolved
Hide resolved
ibm_cloud_sdk_core/token_managers/vpc_instance_token_manager.py
Outdated
Show resolved
Hide resolved
ibm_cloud_sdk_core/token_managers/vpc_instance_token_manager.py
Outdated
Show resolved
Hide resolved
padamstx
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
In addition to @rmkeezer's suggested changes, I also suggested a couple of minor changes to the documentation, plus posed one additional question about the request body for a "create_iam_token" call. I'll approve now to avoid a re-review assuming that review comments are addressed.
ibm_cloud_sdk_core/token_managers/vpc_instance_token_manager.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Keezer <Robert.Keezer@ibm.com>
pyrooka
force-pushed
the
vpc-authenticator
branch
from
6cb4816
to
0795efa
Compare
dpopp07
approved these changes
Oct 29, 2021
ibm_cloud_sdk_core/authenticators/vpc_instance_authenticator.py
Outdated
Show resolved
Hide resolved
ibm_cloud_sdk_core/token_managers/vpc_instance_token_manager.py
Outdated
Show resolved
Hide resolved
ibm_cloud_sdk_core/token_managers/vpc_instance_token_manager.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Keezer <Robert.Keezer@ibm.com>
Co-authored-by: Phil Adams <phil_adams@us.ibm.com>
Co-authored-by: Dustin Popp <dustinpopp@ibm.com>
pyrooka
force-pushed
the
vpc-authenticator
branch
from
1fd91b9
to
7f0f6f2
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Nov 8, 2021
# [3.13.0](v3.12.0...v3.13.0) (2021-11-08) ### Features * **VPCInstanceAuthenticator:** add support for new VPC authentication flow ([#129](#129)) ([5cb1c21](5cb1c21))
|
🎉 This PR is included in version 3.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the VPCInstanceAuthenticator.
This authenticator implements the authentication flow
within a VPC-managed compute resource that is configured to
use the compute resource identity feature.
This involves the use of the compute resource's local
VPC Instance Metadata Service API to retrieve an instance identity
token, and then exchange that token for an IAM access token.
The IAM access token is then used to authenticate outbound REST
API requests by adding an Authorization containing the access token.