Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas #249

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

arshabbir
Copy link
Contributor

@arshabbir arshabbir commented Jul 3, 2024

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

@pyrooka pyrooka changed the title feat(Resource Controller): Added onetime_credentials property in Reso… feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas Jul 5, 2024
@pyrooka pyrooka self-requested a review July 5, 2024 06:59
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good so far, but please attach the result of the integration and examples test run.

@arshabbir
Copy link
Contributor Author

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! All is left is signing the CLA. Please do that because it's required for merging the PR!

…urceInstance and ResourceKey schemas

Signed-off-by: arshabbir <arshabbir@gmail.com>
@pyrooka pyrooka merged commit 3db4b70 into IBM:main Jul 11, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Jul 11, 2024
# [0.55.0](0.54.2...0.55.0) (2024-07-11)

### Features

* **Resource Controller:** add "onetime_credentials" property in ResourceInstance and ResourceKey schemas ([#249](#249)) ([3db4b70](3db4b70))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.55.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants