feat(IAM Identity): Add support for IAM enterprise #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
padamstx
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
The changes look fine, and we can merge the PR as is, but here are a couple of things to consider:
- A lot of the model classes that were included in your PR really only had a change in the copyright year and are otherwise identical to the previous version. For those classes, you can revert the change and effectively remove those from your PR if you like (not required).
- In the integration tests and examples, you are managing the shared id/etag values between operations by manually adding the code to do that. Instead, you could add links to your API definition to describe each shared value (inter-operation dependency) and then the generator will generate the code to save off these values and then also use them in downstream operations.
One additional thing... please post screenshots of the integration tests and examples running clean
...mples/src/main/java/com/ibm/cloud/platform_services/iam_identity/v1/IamIdentityExamples.java
Show resolved
Hide resolved
...am-identity/src/test/java/com/ibm/cloud/platform_services/iam_identity/v1/IamIdentityIT.java
Show resolved
Hide resolved
michaelbeck
force-pushed
the
issue-6829
branch
2 times, most recently
from
ee35a41
to
108978d
Compare
Signed-off-by: Michael Beck <beckm@de.ibm.com>
|
Had to regenerate the SDK to pull in latest changes from the API docs. Here the new test results: Examples: |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Sep 5, 2023
# [0.39.0](0.38.0...0.39.0) (2023-09-05) ### Features * **IAM Identity:** add support for IAM enterprise ([#202](#202)) ([55ccded](55ccded))
|
🎉 This PR is included in version 0.39.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Added support for IAM enterprise feature. Enterprise admins can create templates for account settings and trusted profiles and assign them to accounts and account groups in the enterprise.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
SDK adopters will be able to work with IAM enterprise feature.
Does this PR introduce a breaking change?
Other information
API definition: Staging
Test information:
Integration Tests:
Examples:
examples_java_sdk_2023-07-20.log