feat(IAM Policy Management): add support for policy templates #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
|
Tests passed after latest commit fix: [INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21.978 s
[INFO] Finished at: 2023-05-22T17:07:36-05:00
[INFO] ------------------------------------------------------------------------Integration: [INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38.166 s
[INFO] Finished at: 2023-05-22T17:07:10-05:00
[INFO] ------------------------------------------------------------------------ |
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
…vices-java-sdk into policy-template
padamstx
changed the title
padamstx
approved these changes
May 31, 2023
There was a problem hiding this comment.
The changes are fine as they are, but I'll add the same comment here as I did in the Go PR... it would be a lot better if the API definition defined all the appropriate link objects so that the integration tests and examples code would be generated to support the inter-operation dependencies, etc.
| @@ -90,6 +108,10 @@ protected IamPolicyManagementExamples() { } | |||
| private static String exampleV2PolicyEtag = null; | |||
| private static String exampleCustomRoleId = null; | |||
| private static String exampleCustomRoleEtag = null; | |||
| private static String exampleTemplateId = null; | |||
There was a problem hiding this comment.
Same comments here as in the Go PR about inter-operation dependencies, links, etc.
Signed-off-by: Vivek.Jain3 <vivek.jain3@ibm.com>
|
|
Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Sep 5, 2023
# [0.40.0](0.39.1...0.40.0) (2023-09-05) ### Features * **IAM Policy Management:** add support for policy templates ([#194](#194)) ([6f752c2](6f752c2))
|
🎉 This PR is included in version 0.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Added feature support for Enterprise IAM work, policy templates and get template assigments.
Issue: https://github.ibm.com/IAM/AM-issues/issues/1346
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
SDK adopters will be able to call policy template and assignment APIs.
Does this PR introduce a breaking change?
Other information
API defintion:
Staging
Prod
Test information:
Example Tests:
Integration Tests:
[INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT [INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.397 s - in com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT [INFO] [INFO] Results: [INFO] [INFO] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- maven-failsafe-plugin:3.0.0-M7:verify (default) @ iam-policy-management --- [INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ iam-policy-management --- [INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT.jar [INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/pom.xml to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT.pom [INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT-javadoc.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT-javadoc.jar [INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT-sources.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT-sources.jar [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 38.420 s [INFO] Finished at: 2023-05-18T16:01:23-05:00 [INFO] ------------------------------------------------------------------------