Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect property case #134

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Fix incorrect property case #134

merged 1 commit into from
Feb 7, 2020

Conversation

adamaveray
Copy link
Contributor

The tokenUrl property for the OAuth2 password flow has the Url part incorrectly capitalised (tokenURL), causing false errors. All other properties tested in this validation have the correct case.

@claassistantio
Copy link

claassistantio commented Feb 7, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          56       56           
  Lines        2055     2055           
=======================================
  Hits         1904     1904           
  Misses        151      151
Impacted Files Coverage Δ
...s3/semantic-validators/security-definitions-ibm.js 77.04% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384af4c...a183cd8. Read the comment docs.

Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Thanks for the fix!

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@dpopp07 dpopp07 merged commit 4395600 into IBM:master Feb 7, 2020
dpopp07 pushed a commit that referenced this pull request Feb 7, 2020
## [0.17.1](v0.17.0...v0.17.1) (2020-02-07)

### Bug Fixes

* use correct property case for `tokenUrl` ([#134](#134)) ([4395600](4395600))
@dpopp07
Copy link
Member

dpopp07 commented Feb 7, 2020

🎉 This PR is included in version 0.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants