fix: print error message and the usage menu for an unknown command line argument

[presto21]

When an unsupported option is given, a single-line error is printed. Now, the usage menu is printed along with the single-line error.

Change:

• unsupportedOptionError.js modifies the commander code
• modified index.js file to include the unsupportedOptionError.js file.

Commander code was:

Command.prototype.unknownOption = function(flag) {
if (this._allowUnknownOption) return;
console.error();
console.error(" error: unknown option %s'", flag);
console.error();
process.exit(1);
};

Now:

program.unknownOption = function(flag) {
if (this._allowUnknownOption) return;
console.error();
console.error(" error: unknown option %s'", flag);
console.error();
// this is the extra code added to the function
this.outputHelp();
process.exit(1);
};

[dpopp07]

Nice work! Modifying the base package is creative and works perfectly. Generally, you want to be wary about doing this but in this situation I think it's okay.

I've left a couple comments to address before I approve. Also, the build is failing so you'll need to address that. It may just be because the linter is complaining about the use of var. If that's the case, it actually would be good to add a test for this change.

[dpopp07]

Just a couple more comments. Also, it looks like the test failure was just the linting error, so no test is currently exercising the new behavior. You should add a test in either the "errorHandling" or "optionHandling" test suite

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@05c7164). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage          ?   92.82%           
=========================================
  Files             ?       57           
  Lines             ?     2133           
  Branches          ?        0           
=========================================
  Hits              ?     1980           
  Misses            ?      153           
  Partials          ?        0

Impacted Files	Coverage Δ
src/cli-validator/utils/modified-commander.js	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c7164...7c1aba4. Read the comment docs.

[dpopp07]

Looks good! 👍

[dpopp07]

🎉 This PR is included in version 0.19.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀