Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional cookie jar support #85

Merged
merged 1 commit into from
Mar 23, 2020
Merged

feat: add optional cookie jar support #85

merged 1 commit into from
Mar 23, 2020

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Mar 23, 2020

This adds cookie jar support to Axios using axios-cookiejar-support, so that consumers of the core can provide their own cookie jar management capabilities depending on the needs of their users.

This PR simply adds tests to #84 - I opened a separate PR to avoid commit history conflicts since I rebased onto master and just amended Christian's commit

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpopp07 dpopp07 merged commit 27e0060 into master Mar 23, 2020
@dpopp07 dpopp07 deleted the dp/cookie branch March 23, 2020 19:34
ibm-devx-automation pushed a commit that referenced this pull request Mar 23, 2020
# [2.3.0](v2.2.0...v2.3.0) (2020-03-23)

### Features

* add optional cookie jar support ([#85](#85)) ([27e0060](27e0060))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants