-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace @types/is-stream with correct @types/isstream #52
Conversation
Codecov Report
@@ Coverage Diff @@
## release-v1-rc2 #52 +/- ##
===============================================
Coverage 95.71% 95.71%
===============================================
Files 23 23
Lines 584 584
Branches 125 125
===============================================
Hits 559 559
Misses 24 24
Partials 1 1 Continue to review full report at Codecov.
|
It seems like |
I didn't do that on purpose, so if you think it would be useful feel free to add it |
Would it also make sense to just remove the key and let |
If TypeScript does that, yeah that sounds good to me |
Sounds good, I've commented out that bit of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 👍
This changes the installed
@types
file to use the right typing package for the isstream module that is depended upon concretely.Checklist
npm test
passes (tip:npm run lint-fix
can correct most style issues)