Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace @types/is-stream with correct @types/isstream #52

Merged
merged 3 commits into from
Sep 30, 2019
Merged

chore: replace @types/is-stream with correct @types/isstream #52

merged 3 commits into from
Sep 30, 2019

Conversation

MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Sep 27, 2019

This changes the installed @types file to use the right typing package for the isstream module that is depended upon concretely.

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #52 into release-v1-rc2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1-rc2      #52   +/-   ##
===============================================
  Coverage           95.71%   95.71%           
===============================================
  Files                  23       23           
  Lines                 584      584           
  Branches              125      125           
===============================================
  Hits                  559      559           
  Misses                 24       24           
  Partials                1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dcde61...233129c. Read the comment docs.

@MasterOdin
Copy link
Contributor Author

MasterOdin commented Sep 27, 2019

It seems like @types/file-type is also missing from the types array in the tsconfig.json, though I've never used it so I'm not sure if that was on purpose or not.

@dpopp07
Copy link
Member

dpopp07 commented Sep 27, 2019

I didn't do that on purpose, so if you think it would be useful feel free to add it

@MasterOdin
Copy link
Contributor Author

Would it also make sense to just remove the key and let tsc automatically find the necessary types it needs automatically from the node_modules/@types/ directory?

@dpopp07
Copy link
Member

dpopp07 commented Sep 27, 2019

If TypeScript does that, yeah that sounds good to me

@MasterOdin
Copy link
Contributor Author

MasterOdin commented Sep 27, 2019

Sounds good, I've commented out that bit of the tsconfig.json and will let tsc handle finding the types itself.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@dpopp07 dpopp07 merged commit cd6a4fe into IBM:release-v1-rc2 Sep 30, 2019
dpopp07 pushed a commit that referenced this pull request Oct 3, 2019
dpopp07 pushed a commit that referenced this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants