Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): resolve vulnerability in axios version #256

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Oct 30, 2023

This commit forces a release for the updated axios version that resolved a vulnerability. It also includes build changes to stop testing on Node 14, which had EOL 6 months ago, start testing on Node 20, and document that Node 14 is technically no longer guaranteed, even though it is supported.

@dpopp07 dpopp07 requested a review from padamstx October 30, 2023 19:44
This commit forces a release for the updated axios version that
resolved a vulnerability. It also includes build changes to stop
testing on Node 14, which had EOL 6 months ago, start testing on
Node 20, and document that Node 14 is technically no longer
guaranteed, even though it is supported.

This also fixes a test to be more flexible on different Node
versions, as `JSON.parse()` throws slightly different errors
on Node 18 vs Node 20.

Signed-off-by: Dustin Popp <dpopp07@gmail.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpopp07 dpopp07 merged commit 9bc0358 into main Oct 31, 2023
4 checks passed
@dpopp07 dpopp07 deleted the dp/build-steps branch October 31, 2023 15:18
ibm-devx-sdk pushed a commit that referenced this pull request Oct 31, 2023
## [4.1.4](v4.1.3...v4.1.4) (2023-10-31)

### Bug Fixes

* **deps:** resolve vulnerability in axios version ([#256](#256)) ([9bc0358](9bc0358))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 4.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants