fix: allow for synchronous building of file requests #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing some linting failures (related to async/await within loops, ironically). I'll get those sorted |
padamstx
approved these changes
Oct 21, 2022
This issue was caused by an oversight in adding an `await` statement within a `forEach` loop, which will result in asynchronous operations happening without the synchronous control you'd expect from async/await. This solves the issue by simply converting the loops to "for of" loops. Note that the AirBnb style guide we follow prohibits the use of "for of" loops and that ESLint discourages "await" statements in any kind of loop. However, to adherence to the rules would require a significant refactor that is not current worth the effort. So for now, we are ignoring the rules. Signed-off-by: Dustin Popp <dpopp07@gmail.com>
dpopp07
force-pushed
the
dp/file-request-bug
branch
from
a4934fe
to
316f824
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Oct 21, 2022
## [3.2.1](v3.2.0...v3.2.1) (2022-10-21) ### Bug Fixes * allow for synchronous building of file requests ([#211](#211)) ([dcce4ea](dcce4ea))
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was caused by an oversight in adding an
awaitstatement within aforEachloop, which will result in asynchronous operations happening without the synchronous control you'd expect from async/await.This solves the issue by simply converting the loops to "for of" loops.
This caused a subtle server error so unfortunately, I can't think of a great test case for it. I should've known not to put an
awaitcall within aforEachthough. Logically, this is a simple refactor, but practically it makes the code behave in the way it was actually intended to.cc @apaparazzi0329