Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for retrieving refresh tokens from iam-based authenticators #173

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Oct 20, 2021

This commit moves the refresh token retrieval functionality to the IAM "based"
token manager and authenticator, so that any subclasses can take advantage of.
With this, calling 'getRefreshToken' is now support for both the IAM and
Container authenticators.

…ticators

This commit moves the refresh token retrieval functionality to the IAM "based"
token manager and authenticator, so that any subclasses can take advantage of.
With this, calling 'getRefreshToken' is now support for both the IAM and
Container authenticators.
@dpopp07 dpopp07 requested a review from padamstx October 20, 2021 21:56
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpopp07 dpopp07 merged commit e7f11fc into main Oct 20, 2021
@dpopp07 dpopp07 deleted the dp/refresh-token branch October 20, 2021 22:42
ibm-devx-sdk pushed a commit that referenced this pull request Oct 20, 2021
# [2.16.0](v2.15.1...v2.16.0) (2021-10-20)

### Features

* add support for retrieving refresh tokens from iam-based authenticators ([#173](#173)) ([e7f11fc](e7f11fc))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 2.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants