fix: allow iam client id and secret to be read from constructor #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
+ Coverage 95.54% 95.6% +0.05%
=========================================
Files 7 7
Lines 337 341 +4
Branches 55 56 +1
=========================================
+ Hits 322 326 +4
Misses 13 13
Partials 2 2
Continue to review full report at Codecov.
|
|
I noticed the same thing with Java and was about to get started on the Node-related changes to make it settable by the SDK user :) |
|
We should add a check in token manager to check if secret is provided with client_id |
|
@joyychang We use the defaults if the user passes in only Client ID or Secret. So, the request would not actually fail but it won't do what the user might expect. I added a warning to let the user know that this is the case. @padamstx I didn't catch this before but two of the test titles involved "passing only secret via constructor" - I think one was supposed to be using the setter so I changed that. Let me know if that wasn't the intention |
## [0.2.1](v0.2.0...v0.2.1) (2019-04-29) ### Bug Fixes * allow iam client id and secret to be read from constructor ([#17](#17)) ([3c88edb](3c88edb))
|
🎉 This PR is included in version 0.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Generated SDK source code using: - Generator version 3.12.2 - Specification version 0.0.27 - Automation (cloudant-sdks) version 70e999d
@padamstx added support for IAM Client ID and Secret credentials in the Token Manager, but I realized that users wouldn't be able to pass these credentials into service constructors without additions to the Base Service. This PR adds those changes w/ tests.