-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support 'AUTHTYPE' as alias for 'AUTH_TYPE' config property #153
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,11 +42,11 @@ describe('Get Authenticator From Environment Module', () => { | |
|
||
it('should get basic authenticator', () => { | ||
setUpBasicPayload(); | ||
readExternalSourcesMock.mockImplementation(() => ({ | ||
authType: 'basic', | ||
username: 'a', | ||
password: 'b', | ||
})); | ||
// readExternalSourcesMock.mockImplementation(() => ({ | ||
// authtype: 'basic', | ||
// username: 'a', | ||
// password: 'b', | ||
// })); | ||
const authenticator = getAuthenticatorFromEnvironment(SERVICE_NAME); | ||
expect(authenticator).toBeInstanceOf(BasicAuthenticator); | ||
}); | ||
|
@@ -122,7 +122,7 @@ function setUpNoAuthPayload() { | |
|
||
function setUpBasicPayload() { | ||
readExternalSourcesMock.mockImplementation(() => ({ | ||
authType: 'basic', | ||
authtype: 'basic', | ||
username: 'a', | ||
password: 'b', | ||
})); | ||
|
@@ -152,7 +152,7 @@ function setUpIamPayloadWithScope() { | |
|
||
function setUpCp4dPayload() { | ||
readExternalSourcesMock.mockImplementation(() => ({ | ||
authType: 'cp4d', | ||
authtype: 'cp4d', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is all good and probably sufficient, but if you wanted to throw in one extra test you could add something to |
||
username: 'a', | ||
password: 'b', | ||
authUrl: TOKEN_URL, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be all commented out?