refactor: move iam-specific functionality to a shared class #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow other authenticators that interact with the IAM service to share configuration and functionality.
dpopp07
commented
Aug 3, 2021
| @@ -119,294 +141,5 @@ describe('iam_token_manager_v1', () => { | |||
| const token = await instance.getToken(); | |||
| expect(token).toBe(ACCESS_TOKEN); | |||
| expect(requestMock).not.toHaveBeenCalled(); | |||
| done(); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
All of these tests below were consolidated and are covered by the tests for the new IAM request based token manager
dpopp07
commented
Aug 3, 2021
| expect(logger.verbose.enabled).toBeFalsy(); | ||
| expect(logger.info.enabled).toBeFalsy(); | ||
| expect(logger.error.enabled).toBeFalsy(); | ||
| expect(logger.debug.enabled).toBeFalsy(); |
There was a problem hiding this comment.
These were failing locally. Honestly, I'm not sure how they were ever passing. We never set those fields to false
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow other token managers that interact with the IAM service to share configuration and functionality. This change is being made in advance of a new container-based token manager being added that will utilize this shared functionality, as it will interact with the IAM service as well.
cc @pyrooka