fix: remove default limit on request body length #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `axios` library sets an arbitrary maximum length for request bodies and throws an error if this length is exceeded. This has caused some confusion for users and none of the other core libraries enforce such a limit. Services are expected to handle request body length themselves. So this commit overrides the default to be "Infinity", just like we do for response body limits. Users still have the option to override this limit if they wish.
|
LGTM |
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jun 10, 2021
## [2.11.2](v2.11.1...v2.11.2) (2021-06-10) ### Bug Fixes * remove default limit on request body length ([#145](#145)) ([abf604a](abf604a))
|
🎉 This PR is included in version 2.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
axioslibrary sets an arbitrary maximum length for request bodies andthrows an error if this length is exceeded. This has caused some confusion for
users and none of the other core libraries enforce such a limit. Services are
expected to handle request body length themselves. So this commit overrides the
default to be "Infinity", just like we do for response body limits. Users still
have the option to override this limit if they wish.