feat: add BaseService.constructServiceURL method
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dpopp07
reviewed
May 26, 2021
| // If null was passed, we set the variables to an empty map. | ||
| // This results in all default variable values being used. | ||
| if (providedUrlVariables === null) { | ||
| providedUrlVariables = new Map<string, string>(); |
There was a problem hiding this comment.
Quick initial question - is there a reason that you used Maps instead of basic objects? e.g. {}
There was a problem hiding this comment.
I'm implementing the same method for Java and Go using a map, so I chose the Map class for consistency. The class provides some useful methods like .has(key). I also chose the Map class because the variables are intended to just have keys and values - nothing more nested than that.
There was a problem hiding this comment.
That all makes sense! I asked because I don't see them used very often but they seem great for this use case 👍
ibm-devx-sdk
pushed a commit
that referenced
this pull request
May 27, 2021
# [2.11.0](v2.10.4...v2.11.0) (2021-05-27) ### Features * add `BaseService.constructServiceURL` method ([#138](#138)) ([0e73bde](0e73bde))
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method can be used by an API to construct a service URL from a parameterized URL.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)