feat: adding configureService method for external config options #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 8 8
Branches 1 1
=====================================
Hits 8 8Continue to review full report at Codecov.
|
dpopp07
requested changes
Oct 22, 2019
There was a problem hiding this comment.
Looks good, just two comments.
- I think the new method should be public
- The commit messages are how the changelog is put together, so the message for this PR needs to be descriptive. It should be the feature you are adding, not the issue on our board you're solving. This message is how users will know about the new feature so use a clear but short summary for the header and then more description in the commit body if needed
jorge-ibm
changed the title
jorge-ibm
changed the title
jorge-ibm
changed the title
jorge-ibm
force-pushed
the
service-factory-node
branch
from
915e85f
to
1234f12
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Oct 22, 2019
# [1.3.0](v1.2.0...v1.3.0) (2019-10-22) ### Features * adding configureService method for external config options ([#66](#66)) ([7324919](7324919))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/1118
Changes:
The new method will now be invoked from the generator after the BaseService's constructor is called.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)