fix(auth): migrate to secure usage of jwt for token authentication #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpopp07
force-pushed
the
dp/upgrade-jwt
branch
from
ddb726c
to
117cad4
Compare
There is a vulnerability in v8 of the `jsonwebtoken` dependency. This commit upgrades to v9 to resolve the vulnerability. Additionally, they made an effort in this version to discourage the less secure "decode" method in favor of the more secure "verify" method (1). This commit also refactors the code and tests to use the "verify" method. (1) See this PR for context: auth0/node-jsonwebtoken#741 Signed-off-by: Dustin Popp <dpopp07@gmail.com>
dpopp07
force-pushed
the
dp/upgrade-jwt
branch
from
117cad4
to
bd527f5
Compare
|
Thanks for this, please let us know an update, i think a lot of us have a short deadline to get this fixed, and this is a dep of another dep |
dpopp07
requested review from
apaparazzi0329
and removed request for
rmkeezer
apaparazzi0329
approved these changes
Dec 29, 2022
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Dec 29, 2022
## [4.0.1](v4.0.0...v4.0.1) (2022-12-29) ### Bug Fixes * **auth:** migrate to secure usage of jwt for token authentication ([#225](#225)) ([10e0728](10e0728))
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a vulnerability in v8 of the
jsonwebtokendependency. This commit upgrades to v9 to resolve the vulnerability. Additionally, they made an effort in this version to discourage the less secure "decode" method in favor of the more secure "verify" method. This commit also refactors the code and tests to use the "verify" method.