-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add method getNewLogger
to public API
#210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method will return a new logger configured with a provided name. This can be used by generated service classes to create a new logger specific to its module context. Signed-off-by: Dustin Popp <dpopp07@gmail.com>
padamstx
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
padamstx
reviewed
Oct 11, 2022
Signed-off-by: Dustin Popp <dpopp07@gmail.com>
pyrooka
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few typo.
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Oct 12, 2022
# [3.2.0](v3.1.0...v3.2.0) (2022-10-12) ### Features * add method `getNewLogger` to public API ([#210](#210)) ([07b99de](07b99de))
🎉 This PR is included in version 3.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method will return a new logger configured with a provided name. This can be used by generated service classes to create a new logger specific to its module context.
Signed-off-by: Dustin Popp dpopp07@gmail.com
Checklist
npm test
passes (tip:npm run lint-fix
can correct most style issues)