Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method getNewLogger to public API #210

Merged
merged 7 commits into from
Oct 12, 2022
Merged

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Oct 11, 2022

This method will return a new logger configured with a provided name. This can be used by generated service classes to create a new logger specific to its module context.

Signed-off-by: Dustin Popp dpopp07@gmail.com

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included
  • documentation is changed or added

This method will return a new logger configured with a provided name.
This can be used by generated service classes to create a new logger
specific to its module context.

Signed-off-by: Dustin Popp <dpopp07@gmail.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/unit/get-new-logger.test.js Outdated Show resolved Hide resolved
lib/get-new-logger.ts Outdated Show resolved Hide resolved
Signed-off-by: Dustin Popp <dpopp07@gmail.com>
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few typo.

test/unit/get-new-logger.test.js Outdated Show resolved Hide resolved
test/unit/get-new-logger.test.js Outdated Show resolved Hide resolved
test/unit/get-new-logger.test.js Outdated Show resolved Hide resolved
test/unit/get-new-logger.test.js Outdated Show resolved Hide resolved
test/unit/get-new-logger.test.js Outdated Show resolved Hide resolved
dpopp07 and others added 5 commits October 12, 2022 08:53
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Co-authored-by: Norbert Biczo <pyrooka@users.noreply.github.com>
@dpopp07 dpopp07 merged commit 07b99de into main Oct 12, 2022
@dpopp07 dpopp07 deleted the dp/add-logger-creator branch October 12, 2022 13:59
ibm-devx-sdk pushed a commit that referenced this pull request Oct 12, 2022
# [3.2.0](v3.1.0...v3.2.0) (2022-10-12)

### Features

* add method `getNewLogger` to public API ([#210](#210)) ([07b99de](07b99de))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants