Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update minimum Node version in package.json #192

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Mar 7, 2022

This PR updates the minimum Node version for this package
from v10 to v12. Node.js 10 is no longer supported (see here).
This change also means the minimum TLS version has been set to TLS v1.2 by default.
tls.DEFAULT_MIN_VERSION - Default: 'TLSv1.2' (Added in: v11.4.0) Docs

Checklist
  • npm test passes (tip: npm run lint-fix can correct most style issues)
  • tests are included
  • documentation is changed or added

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@padamstx padamstx requested review from padamstx and ricellis and removed request for padamstx and ricellis March 9, 2022 13:38
@padamstx
Copy link
Member

padamstx commented Mar 9, 2022

@ricellis Sorry, wrong PR :)

@pyrooka pyrooka merged commit dfbebee into main Mar 16, 2022
@pyrooka pyrooka deleted the update-min-node-version branch March 16, 2022 19:02
ibm-devx-sdk pushed a commit that referenced this pull request Mar 16, 2022
## [2.17.12](v2.17.11...v2.17.12) (2022-03-16)

### Bug Fixes

* update minimum Node version in package.json ([#192](#192)) ([dfbebee](dfbebee))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 2.17.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants