Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not read credentials file in webpack override scenario #19

Merged
merged 2 commits into from
May 7, 2019

Conversation

esminerva
Copy link
Contributor

@esminerva esminerva commented May 1, 2019

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #19 into master will increase coverage by 0.55%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage    95.6%   96.15%   +0.55%     
==========================================
  Files           7        7              
  Lines         341      416      +75     
  Branches       56      124      +68     
==========================================
+ Hits          326      400      +74     
- Misses         13       15       +2     
+ Partials        2        1       -1
Impacted Files Coverage Δ
lib/read-credentials-file.ts 93.1% <100%> (+2.62%) ⬆️
lib/helper.ts 100% <0%> (ø) ⬆️
iam-token-manager/v1.ts 100% <0%> (ø) ⬆️
lib/requestwrapper.ts 100% <0%> (ø) ⬆️
lib/base_service.ts 89.51% <0%> (+1.63%) ⬆️
lib/content-type.ts 91.66% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8ee33...0c5b534. Read the comment docs.

@germanattanasio
Copy link
Contributor

I think this will work but we need to test it.
There is an example in the examples folder. If that works when you load it from a browser then we can merge this.

@esminerva
Copy link
Contributor Author

I need to add unit test still too.

@germanattanasio germanattanasio merged commit ec64ae1 into master May 7, 2019
dpopp07 pushed a commit that referenced this pull request May 7, 2019
## [0.2.3](v0.2.2...v0.2.3) (2019-05-07)

### Bug Fixes

* do not read credentials file in webpack override scenario ([9af4567](9af4567))
* do not read credentials file in webpack override scenario ([#19](#19)) ([ec64ae1](ec64ae1))
@dpopp07
Copy link
Member

dpopp07 commented May 7, 2019

🎉 This PR is included in version 0.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@esminerva esminerva deleted the cred-file branch May 7, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants