fix: remove 'module' entry from package.json #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change to the library introduced a separate es6 module for the library to support tree shaking. Unfortunately, if an SDK project doesn't (at a minimum) define the 'main' entry point in its package.json file, then a problem can occur due to an es5 vs es6 incompatibility. This commit provides a tactical fix for this issue by removing the 'module' entry point from the library's package.json. This will prevent webpack from being able to minimize the resulting application code, but it will avoid the problem. Once we have a strategy for rolling out "tree shakability" in various SDK projects, we can re-introduce the 'module' entry point.
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jan 14, 2022
## [2.17.7](v2.17.6...v2.17.7) (2022-01-14) ### Bug Fixes * remove 'module' entry from package.json ([#187](#187)) ([3a0aea5](3a0aea5))
|
🎉 This PR is included in version 2.17.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to the library introduced
a separate es6 module for the library to support
tree shaking. Unfortunately, if an SDK project
doesn't (at a minimum) define the 'main' entry point
in its package.json file, then a problem can occur
due to an es5 vs es6 incompatibility.
This commit provides a tactical fix for this issue
by removing the 'module' entry point from the library's
package.json. This will prevent webpack from being
able to minimize the resulting application code, but
it will avoid the problem.
Once we have a strategy for rolling out "tree
shakability" in various SDK projects, we can
re-introduce the 'module' entry point.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)