fix(VpcInstanceAuthenticator): omit request body for default profile scenario #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpopp07
approved these changes
Dec 8, 2021
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Dec 8, 2021
## [2.17.2](v2.17.1...v2.17.2) (2021-12-08) ### Bug Fixes * **VpcInstanceAuthenticator:** omit request body for default profile scenario ([#181](#181)) ([1e3fb2d](1e3fb2d))
|
🎉 This PR is included in version 2.17.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
JurajNyiri
pushed a commit
to JurajNyiri/node-sdk-core
that referenced
this pull request
Aug 22, 2024
Generated SDK source code using: - Generator version 3.26.0 - Specification version 1.0.0-dev0.0.31 - Automation (cloudant-sdks) version 0ead36e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small problem in the VPC instance token manager related to the "default profile" scenario.
Previously, the token manager would send an empty request body (i.e.
{ }) if bothiamProfileIdandiamProfileCrnwere both unspecified. This would cause a 400 Bad Request to be returned by the VPC Instance Metadata Service.The fix is to simply avoid sending a request body at all for this scenario.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)