fix: support POST for retry-axios #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mojito317
force-pushed
the
support-post-for-retry-axios
branch
from
e663238
to
5c1d934
Compare
mojito317
force-pushed
the
support-post-for-retry-axios
branch
from
5c1d934
to
74f9e24
Compare
dpopp07
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Looks good! 👍
Thanks for the PR. I will wait for @barrett-schonefeld to look at this as well and then I will merge
barrett-schonefeld
approved these changes
Sep 22, 2021
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Sep 22, 2021
## [2.14.4](v2.14.3...v2.14.4) (2021-09-22) ### Bug Fixes * support POST for retry-axios ([#165](#165)) ([6b055d3](6b055d3))
|
🎉 This PR is included in version 2.14.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry does not emit when
POSTrequest is called in the Node SDK. This is happening because the configuration of retry-axios defaults to the['GET', 'HEAD', 'OPTIONS', 'DELETE', 'PUT']verbs (source).I added a test to make sure retry is happening when
POSTis called. This test would fail without the augment.Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)