fix: support 'AUTHTYPE' as alias for 'AUTH_TYPE' config property #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpopp07
approved these changes
Aug 12, 2021
| // authtype: 'basic', | ||
| // username: 'a', | ||
| // password: 'b', | ||
| // })); |
There was a problem hiding this comment.
Is this supposed to be all commented out?
| @@ -152,7 +152,7 @@ function setUpIamPayloadWithScope() { | |||
|
|
|||
| function setUpCp4dPayload() { | |||
| readExternalSourcesMock.mockImplementation(() => ({ | |||
| authType: 'cp4d', | |||
| authtype: 'cp4d', | |||
There was a problem hiding this comment.
This is all good and probably sufficient, but if you wanted to throw in one extra test you could add something to read-external-sources.test.js that ensures something like SERVICE_NAME_AUTHTYPE is in fact converted to authtype in the object returned. Totally up to you, it's fine as is
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 13, 2021
## [2.12.2](v2.12.1...v2.12.2) (2021-08-13) ### Bug Fixes * support 'AUTHTYPE' as alias for 'AUTH_TYPE' config property ([#153](#153)) ([fccf209](fccf209))
|
🎉 This PR is included in version 2.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)