fix: canonicalize iam url #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change forces canonical use of an IAM URL. The standard operation path for a token request is now unconditionally added at request time. If a user provides a URL that includes the path, it will be removed. As it turns out, there were no tests around URL behavior so I added tests that capture it, including the behavior added in this change.
ibm-devx-automation
pushed a commit
that referenced
this pull request
Mar 9, 2021
## [2.8.1](v2.8.0...v2.8.1) (2021-03-09) ### Bug Fixes * canonicalize iam url ([#125](#125)) ([7ce6588](7ce6588))
|
🎉 This PR is included in version 2.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change forces canonical use of an IAM URL. The standard operation path for a token
request is now unconditionally added at request time. If a user provides a URL that
includes the path, it will be removed.
As it turns out, there were no tests around URL behavior so I added tests that capture
it, including the behavior added in this change.