fix: pin typescript dependency to 3.8.3 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3.9 of typescript includes changes that break our code - the exports are generated without "setters", so individual components of this core module cannot be mocked this does not impact operation of the core but it causes issues in the generated unit tests for sdks
ibm-devx-automation
pushed a commit
that referenced
this pull request
Aug 12, 2020
## [2.4.5](v2.4.4...v2.4.5) (2020-08-12) ### Bug Fixes * pin typescript dependency to 3.8.3 ([#107](#107)) ([ef27bc9](ef27bc9))
|
🎉 This PR is included in version 2.4.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.9 of
typescriptincludes changes that break our code. The top-level exports inindex.jsare generated without "setters", so individual components of this core module cannot be mocked in tests.This does not impact normal operation of the code (that I'm aware of - there's reason to redefine any components when using them) but it causes issues in the generated unit tests for SDKs that rely on this package. These tests mock out individual components to isolate behavior. By pinning the dependency to 3.8.3, we can continue to mock these components.
FYI @apaparazzi0329