fix: use extend with deep copy where necessary
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we recently removed extend as a dependency but this caused a bug - the lack of deep copy in Object.assign causes issues putting together query params
dpopp07
force-pushed
the
dp/add-extend-back-in
branch
from
6ebd9a2
to
e471117
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Aug 6, 2020
## [2.4.4](v2.4.3...v2.4.4) (2020-08-06) ### Bug Fixes * use `extend` with deep copy where necessary ([#106](#106)) ([566b81f](566b81f))
|
🎉 This PR is included in version 2.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we removed
extendas a dependency, I didn't think the lack of deep copy would be an issue. That turned out to be incorrect as it caused issues concerning query parameters (and may have allowed issues in other areas as well). The "version" parameter would be overwritten by any query parameters from the generated code.I added
extendback and reinstated every instance that we were using deep copy before. For instances that deep copy was not previously used, I left the code asObject.assign.