fix: use constant defined by generated sdks for url (#77)

this fixes a bug in which generated sdk code would not actually use the default url if none was provided
IBM · Jan 16, 2020 · cb3cc81 · cb3cc81
1 parent 16fdf87
commit cb3cc81
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/base-service.ts b/lib/base-service.ts
@@ -57,7 +57,8 @@ export interface BaseServiceOptions extends UserOptions {
  * them to the service endpoint.
  */
 export class BaseService {
-  static URL: string;
+  static DEFAULT_SERVICE_URL: string;
+  static DEFAULT_SERVICE_NAME: string;
   protected baseOptions: BaseServiceOptions;
   private authenticator: AuthenticatorInterface;
   private requestWrapperInstance;
@@ -108,7 +109,7 @@ export class BaseService {
 
     const serviceClass = this.constructor as typeof BaseService;
     this.baseOptions = extend(
-      { qs: {}, serviceUrl: serviceClass.URL },
+      { qs: {}, serviceUrl: serviceClass.DEFAULT_SERVICE_URL },
       options,
       _options
     );

diff --git a/test/unit/base-service.test.js b/test/unit/base-service.test.js
@@ -395,5 +395,5 @@ function setupFakeService() {
   util.inherits(TestService, BaseService);
   TestService.prototype.name = DEFAULT_NAME;
   TestService.prototype.version = 'v1';
-  TestService.URL = DEFAULT_URL;
+  TestService.DEFAULT_SERVICE_URL = DEFAULT_URL;
 }