fix: move test utilities to lib/ and rely directly on expect (#101)

* fix: move test utilities to lib/ and rely directly on `expect`

this removes any need to include test code in the published package and avoids mixing dev dependencies into the published dependencies

also, update axios-cookie-support to use the latest release and add tough-cookie, as it is now a required peer dependency

.npmignore

@@ -1,6 +1,4 @@
-test/resources
-test/unit
-test/.eslintrc.js
+test
 coverage
 .jshintignore
 .hshintrc

index.ts

@@ -24,4 +24,6 @@ export * from './lib/helper';
 export { default as qs } from './lib/querystring';
 export { default as contentType } from './lib/content-type';
 export * from './lib/stream-to-promise';
-export * from './test/utils';
+
+import * as unitTestUtils from './lib/sdk-test-helpers';
+export { unitTestUtils };

test/utils/unit-test-helpers.ts → lib/sdk-test-helpers.ts

@@ -1,5 +1,5 @@
 /**
- * Copyright 2019 IBM Corp. All Rights Reserved.
+ * Copyright 2019, 2020 IBM Corp. All Rights Reserved.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,15 +14,12 @@
  * limitations under the License.
  */
 
-/* istanbul ignore file */
+import expect = require('expect');
 
 /**
  * This module provides a set of helper methods used to reduce code duplication in the generated unit tests
  * for the SDKs that depend on this core package. Note that these methods are not used by the tests for this
  * package - they are meant to be exported and made available to dependent libraries.
- *
- * They are included in the `test` directory since they rely on `jest` globals (like `expect`) and this
- * requires special linting rules that should not be configured in the rest of the source code.
  */
 
 /**

package.json

@@ -55,13 +55,13 @@
     "@types/extend": "~3.0.0",
     "@types/file-type": "~5.2.1",
     "@types/isstream": "^0.1.0",
-    "@types/jest": "^24.0.23",
     "@types/node": "~10.14.19",
     "axios": "^0.18.1",
-    "axios-cookiejar-support": "^0.5.1",
+    "axios-cookiejar-support": "^1.0.0",
     "camelcase": "^5.3.1",
     "debug": "^4.1.1",
     "dotenv": "^6.2.0",
+    "expect": "^26.1.0",
     "extend": "~3.0.2",
     "file-type": "^7.7.1",
     "form-data": "^2.3.3",
@@ -72,7 +72,7 @@
     "object.omit": "~3.0.0",
     "object.pick": "~1.3.0",
     "semver": "^6.2.0",
-    "ts-jest": "^25.5.1"
+    "tough-cookie": "^4.0.0"
   },
   "browser": {
     "./auth/utils/read-credentials-file": "./auth/utils/read-credentials-file.browser"

test/unit/cookiejar.test.js

@@ -1,10 +1,6 @@
 'use strict';
 
-// the `toBeInstanceOf` assertion compares for function reference equality
-// importing our own `tough-cookie` dependency would create a different function
-// reference and render the assertion unusable. the solution is to use the
-// dependency within axios-cookiejar-support
-const tough = require('axios-cookiejar-support/node_modules/tough-cookie');
+const tough = require('tough-cookie');
 const { RequestWrapper } = require('../../dist/lib/request-wrapper');
 
 describe('cookie jar support', () => {