Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for directlink connection type #36

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

kennburger
Copy link
Member

PR summary

Support for Directlink type gateway connection

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • [X ] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [X ] No

Other information

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #36 (48fe504) into master (c08696e) will decrease coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   88.59%   88.13%   -0.46%     
==========================================
  Files          37       37              
  Lines       23773    23775       +2     
==========================================
- Hits        21061    20954     -107     
- Misses       2712     2821     +109     
Impacted Files Coverage Δ
...oud_networking_services/transit_gateway_apis_v1.py 90.39% <100.00%> (-0.41%) ⬇️
ibm_cloud_networking_services/dns_svcs_v1.py 89.19% <0.00%> (-3.12%) ⬇️
...oud_networking_services/direct_link_provider_v2.py 87.94% <0.00%> (-0.72%) ⬇️
ibm_cloud_networking_services/direct_link_v1.py 89.50% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08696e...48fe504. Read the comment docs.

@kennburger kennburger merged commit 701b11d into master Aug 30, 2021
@kennburger kennburger deleted the tgw_Dlaas branch August 30, 2021 21:30
ajay-malhotra1 pushed a commit that referenced this pull request Aug 30, 2021
# [0.10.0](v0.9.0...v0.10.0) (2021-08-30)

### Features

* support for directlink tgw connection type ([#36](#36)) ([701b11d](701b11d))
@ajay-malhotra1
Copy link
Contributor

🎉 This PR is included in version 0.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants