Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is requests version pin still required? #9

Closed
cletomartin opened this issue Mar 18, 2020 · 5 comments
Closed

Is requests version pin still required? #9

cletomartin opened this issue Mar 18, 2020 · 5 comments

Comments

@cletomartin
Copy link

Hi!

We are having some problems with using ibm-cos-sdk-python-core in some projects that are using other libraries that depends on requests. I think it is due to the current version pinning: c148e85#diff-2eeaed663bd0d25b7e608891384b7298R14.

Is this currently required? Seems like it is not at requirement.txt: https://github.com/IBM/ibm-cos-sdk-python-core/blob/master/requirements.txt#L11. It would be great the top version could be removed so newer versions of requests can be used.

Thanks!

@mdazam1942
Copy link

I'm having similar issues. The latest version of request is 2.23.0 but setup.py has a declaration that restricts the latest version of request library which is a problem if we use both request and cos sdk in one project.

'requests>=2.18,<2.23 ',

@cletomartin
Copy link
Author

Any update on this?

@IBMeric
Copy link
Member

IBMeric commented Mar 27, 2020

Sorry for the late reply and thank you for bringing this to our attention. The version pinning on requests is too restrictive. We are updating internally to <3.0 for the upcoming 2.6.1 patch release. Our internal testing shows no issues, and this aligns with the requests team's release process of no breaking changes without increasing the major version number. Feel free to update your local copy until the patch release becomes available.

@IBMeric
Copy link
Member

IBMeric commented Apr 15, 2020

Version 2.6.2 is now available (2.6.1 was deprecated). If the problem has been resolved, please close this issue. Thanks!

@rtveitch
Copy link
Member

Closing this. Let us know if it's still a problem, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants