Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont panic in SetBodyContent when nonJSONContent is nil #75

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Sep 25, 2020

Fixes a bug in which not setting any body type lead to an attempt to reflect the type of a nil object, which caused a panic. Explicitly handles the case in which all three potential body objects are nil. Adds a test for this case.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpopp07 dpopp07 merged commit 23dfbd4 into master Sep 25, 2020
@dpopp07 dpopp07 deleted the dp/fix-nil-pointer-issue branch September 25, 2020 19:30
ibm-devx-automation pushed a commit that referenced this pull request Sep 25, 2020
## [4.5.1](v4.5.0...v4.5.1) (2020-09-25)

### Bug Fixes

* dont panic in SetBodyContent when nonJSONContent is nil ([#75](#75)) ([23dfbd4](23dfbd4))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 4.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants