Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constructServiceURL function #119

Merged
merged 6 commits into from
Jun 2, 2021
Merged

Conversation

ajhynes7
Copy link
Contributor

@ajhynes7 ajhynes7 commented May 28, 2021

This function can be used by an API to construct a service URL from a parameterized URL.

@ajhynes7 ajhynes7 requested a review from padamstx May 28, 2021 18:39
@CLAassistant
Copy link

CLAassistant commented May 28, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but I suggested a few improvements.

v5/core/parameterized_url.go Outdated Show resolved Hide resolved
v5/core/parameterized_url.go Show resolved Hide resolved
v5/core/parameterized_url.go Outdated Show resolved Hide resolved
From the [Go docs](https://blog.golang.org/maps):

> A nil map behaves like an empty map when reading.
It won't be much of a speed difference since we're dealing with a small number of variables.
@ajhynes7 ajhynes7 requested a review from padamstx June 1, 2021 17:46
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 8213faa into main Jun 2, 2021
@padamstx padamstx deleted the support_parameterized_url branch June 2, 2021 04:07
ibm-devx-sdk pushed a commit that referenced this pull request Jun 2, 2021
# [5.5.0](v5.4.5...v5.5.0) (2021-06-02)

### Features

* add `constructServiceURL` function ([#119](#119)) ([8213faa](8213faa))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

pyrooka pushed a commit that referenced this pull request Jul 8, 2021
# [5.5.0](v5.4.5...v5.5.0) (2021-06-02)

### Features

* add `constructServiceURL` function ([#119](#119)) ([8213faa](8213faa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants