-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Changes to Demo notebook from Rebased notebook branch #89
Conversation
b8a0651
to
270f3e5
Compare
Is this a replacement for #80? |
270f3e5
to
46b9ee5
Compare
Signed-off-by: David Wood <dawood@us.ibm.com>
Signed-off-by: Shivdeep Singh <Shivdeep.Singh@ibm.com>
Signed-off-by: himapatel <himapatel@in.ibm.com>
46b9ee5
to
10f2823
Compare
Some APIs are based on old codebase. Need to repush the notebook with new apis |
Signed-off-by: Shivdeep Singh <Shivdeep.Singh@ibm.com>
There are more changes pending/merged in PR #106 . |
Added section fore xample notebook. Signed-off-by: Shivdeep Singh <Shivdeep.Singh@ibm.com>
Signed-off-by: Shivdeep Singh <Shivdeep.Singh@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
updated notebook to include imports from latests paths as updated in#PR106 |
2. After dependancies are installed, we can launch the jupyter notebook | ||
|
||
`make jupyter` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we suggest a zip file for use? Petros used our repo. Maybe that can work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that is a good starting point till we get data approved.
Why are these changes needed?
Documentation changes to the notebook.