Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add image_pull_secrets parameter to add_settings_to_comp #914

Closed
1 of 2 tasks
roytman opened this issue Jan 5, 2025 · 2 comments
Closed
1 of 2 tasks

[Feature] Add image_pull_secrets parameter to add_settings_to_comp #914

roytman opened this issue Jan 5, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@roytman
Copy link
Member

roytman commented Jan 5, 2025

Search before asking

  • I searched the issues and found no similar issues.

Component

KFP workflows, Library/kfp

Feature

Currently KFPv2 doesn't allow to set imagePullSecrets on the pipeline level, as we did in KFPv1. See KFP 11498.
As a workaround, the secrets can be set per each component. To simplify this process, we need to extend the add_settings_to_comp method by adding an additional optional argument - imagePullSecrets

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@juancappi
Copy link
Contributor

I can confirm the pull secret injection works with the fix. I had to install the module from sources (I believe there is not a new module version published).

@roytman
Copy link
Member Author

roytman commented Jan 7, 2025

fixed by #915

@roytman roytman closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants