From 0bef9b24d0c1628795f71a1f08300b5c7ceae141 Mon Sep 17 00:00:00 2001 From: Ben Cox <1038350+ind1go@users.noreply.github.com> Date: Wed, 6 Nov 2019 08:58:09 +0000 Subject: [PATCH 1/2] Fail build when Javadoc has warnings Signed-off-by: Ben Cox <1038350+ind1go@users.noreply.github.com> --- pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pom.xml b/pom.xml index a011cdc..5a819e3 100644 --- a/pom.xml +++ b/pom.xml @@ -104,6 +104,9 @@ + + true + org.sonatype.plugins From 82e00a7a9b6d1f4de259277504002792112a5361 Mon Sep 17 00:00:00 2001 From: Ben Cox <1038350+ind1go@users.noreply.github.com> Date: Wed, 6 Nov 2019 09:00:51 +0000 Subject: [PATCH 2/2] Fix Javadoc warnings Signed-off-by: Ben Cox <1038350+ind1go@users.noreply.github.com> --- src/main/java/com/ibm/cics/bundle/parts/OsgiBundlePart.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/ibm/cics/bundle/parts/OsgiBundlePart.java b/src/main/java/com/ibm/cics/bundle/parts/OsgiBundlePart.java index 0c051c6..06342aa 100644 --- a/src/main/java/com/ibm/cics/bundle/parts/OsgiBundlePart.java +++ b/src/main/java/com/ibm/cics/bundle/parts/OsgiBundlePart.java @@ -59,7 +59,8 @@ public static String convertMavenVersionToOSGiVersion(String mavenVersion) { /** * Gets the Bundle-Version header inside the given artifact's manifest. - * @param a The Artifact to find the Bundle-Version of + * @param osgiBundle The OSGi bundle file to find the Bundle-Version of + * @throws IOException if an I/O error has occurred * @return The version or null if the manifest, or the header in the manifest, is not present */ public static String getBundleVersion(File osgiBundle) throws IOException { @@ -72,7 +73,7 @@ public static String getBundleVersion(File osgiBundle) throws IOException { * or will search inside a directory, if (as happens during incremental builds in the IDE), the artifact file * is still pointing into the classes directory. * - * @param a The file to read the manifest from + * @param osgiBundle The OSGi bundle file to find the Bundle-Version of * @throws IOException if there was a problem reading the manifest * @return The manifest, or null if none was found */