Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prettier): add svelteBracketNewLine #281

Merged
merged 1 commit into from
Sep 24, 2020
Merged

feat(prettier): add svelteBracketNewLine #281

merged 1 commit into from
Sep 24, 2020

Conversation

josefaidt
Copy link
Contributor

fixes #280

Description

  • adds new Prettier key svelteBracketNewLine
  • runs prettier command to adhere to new style

@josefaidt josefaidt requested a review from metonym September 24, 2020 15:51
metonym
metonym approved these changes Sep 24, 2020
View reviewed changes
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this offline and I agree the having the bracket on the next line makes it more readable, especially when skimming diffs.

@metonym metonym merged commit 1e6369a into carbon-design-system:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(prettier): add svelteBracketNewLine
2 participants
@josefaidt @metonym