Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Sort Direction to the header click dispatch #188

Conversation

mabentley85
Copy link
Contributor

@mabentley85 mabentley85 commented Jun 4, 2020

Also added sortCurrentData to control whether or not the current table data is sorted.

This features will aid in the integrating outside data sources, as you'll most likely want to make a new API call when the sorting column or direction is changed.

Issue #186

Added `sortCurrentData` to control whether or not the curent table data is sorted or not
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as possible, please keep PRs focused. This PR addresses #186 but introduces an additional change to the API. Open a separate issue as you see fit.

@mabentley85
Copy link
Contributor Author

@metonym OK, I removed the sortCurrentData boolean.

I will create a new issue for how to address preventing a DataTable from sorting it's current row.

@metonym metonym self-requested a review June 5, 2020 00:33
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for understanding. Focused PRs are faster to integrate 👍

@metonym metonym merged commit 44c861a into carbon-design-system:master Jun 5, 2020
@mabentley85 mabentley85 deleted the include-sort-direction-in-datatable-click-header-dispatch branch June 5, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants