Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button with Icon does not obey Icon Spacing #174

Closed
arcfide opened this issue May 8, 2020 · 2 comments
Closed

Button with Icon does not obey Icon Spacing #174

arcfide opened this issue May 8, 2020 · 2 comments
Assignees
@metonym
Labels
bug Something isn't working

Comments

@arcfide
Copy link

arcfide commented May 8, 2020

In 0.5.1 when a Button is used with text and an Icon, the Icon appears right next to the text, rather than the Icon being offset.

<Button kind="primary" type="submit" icon={ArrowRight16}>
        Let's Play!
      </Button>
@metonym
Copy link
Collaborator

metonym commented May 8, 2020 •
edited
Loading

Thank you @arcfide for raising this issue.

In Button.svelte, the bug is caused by hasIconOnly incorrectly evaluating to true.

@metonym metonym self-assigned this May 8, 2020
@metonym metonym added the bug Something isn't working label May 8, 2020
@metonym metonym closed this as completed in 89ec5fb May 8, 2020
@metonym
Copy link
Collaborator

metonym commented May 8, 2020

Released in v0.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metonym metonym

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arcfide @metonym