This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
fix(tooltip): remove aria-owns attribute #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-components-react ready! Built with commit ce80640 https://deploy-preview-2273--carbon-components-react.netlify.com |
dakahn
changed the title
asudoh
approved these changes
Apr 24, 2019
emyarod
approved these changes
Apr 26, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1931
We had a div with an
aria-ownsattribute with anidthat doesn't belong to any other element. Looked like a bug, but when I investigated further I don't think we need this attribute set at all.This attribute is not exposed by the component's API so I wouldn't' consider this a breaking change 🤷♂️.
I tested with NVDA on Windows 10 and the toggletip button reads as a button and when the toggletip is expanded it's announced properly and read.
Changelog